Repository navigation
fix(scripts): version-switch.sh says whether the start warned of plugins.toml - #3255
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
scripts/version-switch.shreported a plugin that a 0.46 → main upgrade turned back on as "on again, silently". Since #3239 (shortened in #3245) main warns at every start of a home that still has 0.46'splugins.tomland no[plugins]table insettings.toml(the state a 0.46 home is in afterrig plugin disablethere):so "silently" was wrong for the upgrade. It is still right for the downgrade: v0.46.0 knows nothing of
[plugins]and says nothing.The check now looks at the stderr of the turn just before it. When that turn named
plugins.toml, the detail says so; otherwise it still says "silently". The check's result (XFAIL for both pairs) doesn't change.Before (a release-PR run's summary, from a 0.46.0 → main run):
After, on the same logs:
scripts/version-switch-expected.txt's comment forsettings-upgradeno longer says "silently" either.Changelog
None (a maintainer script's output text).
Migration
None.
Type of change
Testing
bash -n scripts/version-switch.sh.checkandplugin_offfunctions, taken from main's and this branch's script, on the recorded logs of an earlier full 0.46.0 → main run (itsupgrade.errhas the warning above, itsdowngrade.errdoesn't). Output above: main says "silently" for both, this branch only for the downgrade.Line deltas: script +6 / −3, no Rust.
Notes
Try it (a full run, about half an hour of builds):